On Wed, 28 Nov 2018 18:12:25 +0100, Hans de Goede wrote:
Hi,
On 28-11-18 10:56, Takashi Iwai wrote:
We have placed UCM profile snippets to be included by the main config files also in the same directory, src/conf/ucm, it confuses alsaucm program that scans over all subdirectories. It thinks such a file is also the main config file, and spews errors like: % alsaucm ALSA lib utils.c:67:(uc_mgr_config_load) could not open configuration file /usr/share/alsa/ucm/bytcr/bytcr.conf ALSA lib parser.c:1427:(load_master_config) error: could not parse configuration for card bytcr alsaucm: unable to obtain card list: No such file or directory
Actually we already defined the subdirectory for such components, and they are skipped at parsing the main configs. So we just need to move the files there -- this is what's done here.
One more thing done here is to add a new component subdirectory, platforms, for definitions bytcr/* that don't match with neither the existing ones (codecs nor dsps).
Suggested-by: Hans de Goede hdegoede@redhat.com Acked-by: Jaroslav Kysela perex@perex.cz Signed-off-by: Takashi Iwai tiwai@suse.de
Thank you, looks good to me. I've also given this a test run on a bytcr device with a rt5640 codec and everything still works fine:
Reviewed-by: Hans de Goede hdegoede@redhat.com Tested-by: Hans de Goede hdegoede@redhat.com
OK, I pushed the fix now.
Also I have another patch to set the ucm subdirectory as the default search path, so that you don't have to set searchdir:ucm at each config. Will submit soon later.
thanks,
Takashi