On Sun, 18 Oct 2015 08:30:07 +0200, Ricard Wanderlof wrote:
and you're not the first person to mention this checkpatch complaint, so feel free to kill them.
would it be worth while cleaning up the file?
Yes, it would be worth while cleaning up the file by restoring the proper VID/PID order of the entries. :)
I hadn't even noticed that. I suppose it does not really make that much of a difference, as if you're looking for a specific device you'd just do an ordinary search through the file. But of course it makes sense if nothing else as it makes it clear exactly where to add a new entry.
The advantage of ordering in the id number is to catch / avoid doubly entries. Just for reading, grouping with the same quirk type would be better, but this often results in duplicated entries without noticing.
Takashi