Liam Girdwood liam.girdwood@wolfsonmicro.com writes:
I've committed both to git now. We can upstream when the dependencies are committed. Just some minor comments below.
Ah. So, how should I provide the corrections : - with another full patch ? - a differential patch to the previous one ?
Fwiw, there is a thermal IRQ on the WM9713 and you may want to use it for monitoring this. However it only interrupts at 150C so it may be a little high for this purpose.
Well, I compared the temperature to my frying pan. The pan is hotter, so I assume the heat dissipated raises the temperature to about 70 degrees Celsius.
This is still pending atm.
No problem, I'm very patient.
If it depends on mode then have a look at the scenario/use case/mode manager for ALSA :-
OK. Will look.
This could be shortened to :-
return rear_amp_power(codec, SND_SOC_DAPM_EVENT_ON(event));
Absolutely.
+static void mioa701_wm9713_exit(struct snd_soc_card *card) +{
I assume this will never be called in real life phone usage. If it is you could optionally shutdown/slow down the AC97 link to save power.
Yes, it's never called, unless build as module, and then it makes sense. I'll post an update for this.
-- Robert