Takashi,
Thanks a lot, and sorry for the coding style.
Pavel.
------------ Původní zpráva ------------ Od: Takashi Iwai tiwai@suse.de Předmět: Re: EMU 1212 - 16 capture channels - patch Datum: 04.6.2007 15:05:46
At Thu, 31 May 2007 23:10:22 +0200 (CEST), dustin@seznam.cz wrote:
Hello,
Here is the patch increasing number of capture channels from 8 to 16. In this
patch the unused PCMs are not removed yet, I have not been able to test thoroughly to confirm they are 100% sure useless.
As a next project, I would like to try to raise playback resolution from the
current 16bits to 24 (32) bits, using audigy DSP instructions, inversion of the convert32to2x16 function. I would really appreciate comments and suggestions from experts on this card regarding feasibility and possible caveats.
Patch description:
- adding 8 more 32-bit capture channels (total of 16) for emu1010 cards
- adding some code comments and card details description
Signed-off-by: Pavel Hofman dustin@seznam.cz
Thanks for the patch. The changes appear OK (as I have no hardware for testing), but please try to follow the standard coding style. Namely,
- don't put space after '('
- keep 80 chars in a line (including comments) fold lines appropriately
- don't put braces { } for a single if-else command
Anyway, the patch will be merged after 1.0.14, so don't worry about the delay :)
Takashi