Re: [alsa-devel] [PATCH 2/3] ASoC: Blackfin: Add bf5xx-adau1701 machine driver

On Fri, Jun 10, 2011 at 07:18:50PM +0200, Lars-Peter Clausen wrote:

Add a machine driver to support the ADAU1701 SigmaDSP processors on Analog Devices BF5XX evaluation boards.

So, I keep on complaining about the way these drivers are just generic to any random Blackfin plus CODEC combination rather than being board specific. It'd be good if we could improve this, even adding something into the driver name to make it clear these are for the EVB would help.

But it's about the same as all the other drivers so...

+static struct snd_soc_dai_link bf5xx_adau1701_dai[] = {

• {

• .name = "adau1701",
  

• .stream_name = "adau1701",
  

• .cpu_dai_name = "bfin-i2s.0",
  

• .codec_dai_name = "adau1701",
  

• .platform_name = "bfin-i2s-pcm-audio",
  

• .codec_name = "adau1701.0-0034",
  

• .ops = &bf5xx_adau1701_ops,
  

• },
• {

• .name = "adau1701",
  

• .stream_name = "adau1701",
  

• .cpu_dai_name = "bfin-i2s.1",
  

• .codec_dai_name = "adau1701",
  

• .platform_name = "bfin-i2s-pcm-audio",
  

• .codec_name = "adau1701.0-0034",
  

• .ops = &bf5xx_adau1701_ops,
  

• },

For example this mapping could vary between systems, and I guess there may be some possiblity that the CODEC I2C address could change.