Re: [PATCH 1/2] ASoC: dt-bindings: qcom,lpass-tx-macro: Add SM6115

On 26/08/2023 11:37, Konrad Dybcio wrote:

On 26.08.2023 11:32, Krzysztof Kozlowski wrote:

...

On 25/08/2023 19:23, Konrad Dybcio wrote:

...

SM6115 has a TX Macro, requiring an NPL clock, but not DCODEC. Document it.

...

...

• • if:

•  properties:
  

•    compatible:
  

•      enum:
  

•        - qcom,sm6115-lpass-tx-macro
  

• then:

•  properties:
  

•    clocks:
  

•      minItems: 4
  

•      maxItems: 4
  

•    clock-names:
  

•      items:
  

•        - const: mclk
  

•        - const: npl
  

•        - const: dcodec
  

•        - const: fsgen
  

Are you sure there is no macro? This means there will be no LPASS_HW_MACRO_VOTE vote.

Yes.

Do you have downstream sources somewhere? Also yes, but they're not public..

Indeed. Looks correct:

Reviewed-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org

Best regards, Krzysztof