On Mon, 17 Mar 2014 16:43:39 +0000 Mark Brown broonie@kernel.org wrote:
On Sat, Mar 15, 2014 at 12:30:05PM +0100, Jean-Francois Moine wrote:
[snip]
+sound {
- compatible = "simple-audio-card";
- simple-audio-card,name = "Cubox Audio";
- simple-audio-card,cpu@0 { /* I2S - HDMI */
sound-dai = <&audio1 0>;format = "i2s";- };
- simple-audio-card,codec@0 {
sound-dai = <&tda998x 0>;- };
- simple-audio-card,cpu@1 { /* S/PDIF - HDMI */
sound-dai = <&audio1 1>;- };
- simple-audio-card,codec@1 {
sound-dai = <&tda998x 1>;- };
So, this is not exactly pretty as a binding. I would expect to see the links explicitly represented in the DT so you see the two DAIs in each link grouped into a container, the above isn't very easy to read and as Jyri says this lack of clarity also causes practical problems in that there's nowhere to place link specific parameters.
I think what I'd expect to see here is that the simple card can either be a container with a link in it directly or a container of links.
I agree. I see two possible syntaxes:
1) keep the same definitions in the containers:
sound { compatible = "simple-audio-card"; simple-audio-card,name = "Cubox Audio";
simple-audio-card,dai-link@0 { /* I2S - HDMI */ simple-audio-card,cpu { sound-dai = <&audio1 0>; format = "i2s"; }; simple-audio-card,codec { sound-dai = <&tda998x 0>; }; };
simple-audio-card,dai-link@1 { /* S/PDIF - HDMI */ simple-audio-card,cpu { sound-dai = <&audio1 1>; }; simple-audio-card,codec { sound-dai = <&tda998x 1>; } }; ...
2) new definitions in the container
sound { compatible = "simple-audio-card"; simple-audio-card,name = "Cubox Audio";
simple-audio-card,dai-link@0 { /* I2S - HDMI */ format = "i2s"; cpu-dai = <&audio1 0>; codec-dai = <&tda998x 0>; };
simple-audio-card,dai-link@1 { /* S/PDIF - HDMI */ cpu-dai = <&audio1 1>; codec-dai = <&tda998x 1>; }; ...
The 2nd syntax is simpler and clearer, but the properties of the CPU DAI and of the CODEC DAI are the same in the container (format, clock and PCM slots). Is this a problem?
BTW, there is a 'dai_fmt' in the DAI link, but this format is not used in the simple-card. Why?