Re: [alsa-devel] [PATCH 1/4] ALSA: line6: Add toneport_has_source_select()

At Fri, 6 Feb 2015 08:51:09 -0600, Chris Rorvick wrote:

Add a predicate for testing if the device supports source selection to make the conditional logic around this a bit cleaner.

Signed-off-by: Chris Rorvick chris@rorvick.com

sound/usb/line6/toneport.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/sound/usb/line6/toneport.c b/sound/usb/line6/toneport.c index b107cf4..de56180a 100644 --- a/sound/usb/line6/toneport.c +++ b/sound/usb/line6/toneport.c @@ -343,6 +343,20 @@ static void toneport_remove_leds(struct usb_line6_toneport *toneport) } }

+static bool toneport_has_source_select(struct usb_line6_toneport *toneport) +{

• switch (toneport->type) {
• case LINE6_TONEPORT_UX1:
• case LINE6_TONEPORT_UX2:
• case LINE6_PODSTUDIO_UX1:
• case LINE6_PODSTUDIO_UX2:

• return 1;
  

• default:

• return 0;
  

Please use true and false.

Takashi