On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote:
From: Allen-KH Cheng Allen-KH.Cheng@mediatek.com
This patch is to for MediaTek ADSP IPC mailbox controller driver It is used to send short messages between processors with adsp
Reviewed-by: Tzung-Bi Shih tzungbi@google.com Reviewed-by: AngeloGioacchino Del Regnoangelogioacchino.delregno@collabora.com Signed-off-by: Allen-KH Cheng Allen-KH.Cheng@mediatek.com
Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below.
With the minor comments: Reviewed-by: Tzung-Bi Shih tzungbi@google.com
diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
+static const struct mbox_chan_ops adsp_mbox_chan_ops = {
- .send_data = mtk_adsp_mbox_send_data,
- .startup = mtk_adsp_mbox_startup,
- .shutdown = mtk_adsp_mbox_shutdown,
- .last_tx_done = mtk_adsp_mbox_last_tx_done,
+};
Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me.