On Fri, Jul 31, 2015 at 10:23:50AM +0530, Vinod Koul wrote:
On Thu, Jul 30, 2015 at 08:01:04PM +0100, Mark Brown wrote:
On Thu, Jul 30, 2015 at 08:45:07AM +0530, Vinod Koul wrote:
| This series adds NHLT table support in the driver. This also adds support | for dsp init, modules configuration and messaging support
One issue I should probably highlight is - what is a NHLT table and has is it documented (I guess it is part of some part of some ACPI spec given my understanding of the rules on publication of ACPI bindings).
On your questions above, one thing I would like to point that typically we have alsa controls and dapm widgets to model the DSP, but now with topology core, we have moved these into the usermode.
I'm not sure how that's relevant?
In driver we have handlers for the topology events, so yes it becomes little difficult to visualize but we can do better by adding comments. This series is mostly helper code for getting topology created in DSP and next (last series in current SKL driver work) series will add topology handlers which will use these helpers, so the big picture will be clear easily and complete flow can be visualized when these helpers are invoked.
Right, but you're sending all this stuff piecemeal with no advance explanation of where we're going. This is a recurring problem here - there's lots of Intel specific abstraction layers which aren't terribly clear and some of which seem to turn out to be redundant on review.