On Tue, Mar 6, 2012 at 9:12 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
This is not what the above prototype says, the above prototype has only one register in it. You need to make this *much* clearer for the registers it's affecting.
Sorry, I couldn't understand your saying / concern. Do you mean I shouldn't use ml26124_update_bits() but snd_soc_update_bits() ?
Ideally you should be using the framework features. If there is some reason why you can't you need to make it much clearer what the reason is so people reading the code can understand.
If possible, I want to use framework features. However, I judged it is not possible. Let me confirm again. As I said before, all ML26124 registers need to be accessed by different address when read and write. Like below R W $00h $01h Sampling setting $02h $03h PLL setting ...
Even so, can I use framework features ?
thanks,