On Tue, 2017-04-25 at 16:52 +0100, Mark Brown wrote:
On Mon, Apr 24, 2017 at 05:08:41PM +0100, Richard Fitzgerald wrote:
The Cirrus Logic Madera codecs are a family of related codecs with extensive digital and analogue I/O, digital mixing and routing, signal processing and programmable DSPs.
Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing.
+Required properties:
- compatible : One of the following chip-specific strings:
"cirrus,cs47l35-codec""cirrus,cs47l85-codec""cirrus,cs47l90-codec"You shouldn't have compatible strings for subfunctions of a MFD unless these represent meaningful reusable IPs that can exist separately from the parent chip, that's clearly not the case here. All you're doing here is encoding Linux internal abstractions which aren't OS neutral and might change in future (for example clocking might move more into the clock API).
While that's nice, the of_node doesn't get populated if there isn't a compatible string. And people don't like workarounds for the missing of_node.