On Fri, Nov 04, 2022 at 02:18:22PM +0100, Maxime Ripard wrote:
The determine_rate hook allows to select the proper parent and its rate for a given clock configuration. On another hand, set_parent is there to change the parent of a mux.
Some clocks provide a set_parent hook but don't implement determine_rate. In such a case, set_parent is pretty much useless since the clock framework will always assume the current parent is to be used, and we will thus never change it.
This situation can be solved in two ways:
- either we don't need to change the parent, and we thus shouldn't implement set_parent;
- or we don't want to change the parent, in this case we should set CLK_SET_RATE_NO_REPARENT;
- or we're missing a determine_rate implementation.
The latter is probably just an oversight from the driver's author, and we should thus raise their awareness about the fact that the current state of the driver is confusing.
It's not clear at this point how many drivers are affected though, so let's make it a warning instead of an error for now.
Commit message could probably use updated to make the new state of the chain.
Thanks, Charles