Hi Viorel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on asoc/for-next] [also build test ERROR on v5.0 next-20190304] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Viorel-Suman/Add-NXP-AUDMIX-device-... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 8.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.2.0 make.cross ARCH=xtensa
All errors (new ones prefixed by >>):
In file included from include/linux/printk.h:331, from include/linux/kernel.h:14, from include/linux/clk.h:16, from sound/soc/fsl/fsl_audmix.c:8: sound/soc/fsl/fsl_audmix.c: In function 'fsl_audmix_state_trans':
include/linux/dynamic_debug.h:80:13: error: initializer element is not constant
.format = (fmt), \ ^ include/linux/dynamic_debug.h:99:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY' DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, .key.dd_key_false, \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:133:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA' DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/device.h:1473:2: note: in expansion of macro 'dynamic_dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~ sound/soc/fsl/fsl_audmix.c:93:3: note: in expansion of macro 'dev_dbg' dev_dbg(comp->dev, prm.msg); ^~~~~~~ include/linux/dynamic_debug.h:80:13: note: (near initialization for 'descriptor.format') .format = (fmt), \ ^ include/linux/dynamic_debug.h:99:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY' DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, .key.dd_key_false, \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:133:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA' DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/device.h:1473:2: note: in expansion of macro 'dynamic_dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~ sound/soc/fsl/fsl_audmix.c:93:3: note: in expansion of macro 'dev_dbg' dev_dbg(comp->dev, prm.msg); ^~~~~~~ -- In file included from include/linux/printk.h:331, from include/linux/kernel.h:14, from include/linux/clk.h:16, from sound/soc//fsl/fsl_audmix.c:8: sound/soc//fsl/fsl_audmix.c: In function 'fsl_audmix_state_trans':
include/linux/dynamic_debug.h:80:13: error: initializer element is not constant
.format = (fmt), \ ^ include/linux/dynamic_debug.h:99:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY' DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, .key.dd_key_false, \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:133:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA' DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/device.h:1473:2: note: in expansion of macro 'dynamic_dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~ sound/soc//fsl/fsl_audmix.c:93:3: note: in expansion of macro 'dev_dbg' dev_dbg(comp->dev, prm.msg); ^~~~~~~ include/linux/dynamic_debug.h:80:13: note: (near initialization for 'descriptor.format') .format = (fmt), \ ^ include/linux/dynamic_debug.h:99:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY' DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, .key.dd_key_false, \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:133:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA' DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/device.h:1473:2: note: in expansion of macro 'dynamic_dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~ sound/soc//fsl/fsl_audmix.c:93:3: note: in expansion of macro 'dev_dbg' dev_dbg(comp->dev, prm.msg); ^~~~~~~
vim +80 include/linux/dynamic_debug.h
ffa10cb4 Jason Baron 2011-08-11 68 b9075fa9 Joe Perches 2011-10-31 69 extern __printf(3, 4) 906d2015 Joe Perches 2014-09-24 70 void __dynamic_netdev_dbg(struct _ddebug *descriptor, ffa10cb4 Jason Baron 2011-08-11 71 const struct net_device *dev, b9075fa9 Joe Perches 2011-10-31 72 const char *fmt, ...); ffa10cb4 Jason Baron 2011-08-11 73 9049fc74 Jason Baron 2016-08-03 74 #define DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, key, init) \ c0d2af63 Joe Perches 2012-10-18 75 static struct _ddebug __aligned(8) \ 07613b0b Jason Baron 2011-10-04 76 __attribute__((section("__verbose"))) name = { \ 07613b0b Jason Baron 2011-10-04 77 .modname = KBUILD_MODNAME, \ 07613b0b Jason Baron 2011-10-04 78 .function = __func__, \ 07613b0b Jason Baron 2011-10-04 79 .filename = __FILE__, \ 07613b0b Jason Baron 2011-10-04 @80 .format = (fmt), \ 07613b0b Jason Baron 2011-10-04 81 .lineno = __LINE__, \ 07613b0b Jason Baron 2011-10-04 82 .flags = _DPRINTK_FLAGS_DEFAULT, \ 9049fc74 Jason Baron 2016-08-03 83 dd_key_init(key, init) \ 07613b0b Jason Baron 2011-10-04 84 } 07613b0b Jason Baron 2011-10-04 85
:::::: The code at line 80 was first introduced by commit :::::: 07613b0b5ef8570033aa806d1731dce599862223 dynamic_debug: consolidate repetitive struct _ddebug descriptor definitions
:::::: TO: Jason Baron jbaron@redhat.com :::::: CC: Greg Kroah-Hartman gregkh@suse.de
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation