Re: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

On 09/02/2014 02:56 PM, Xiubo Li wrote:

Signed-off-by: Xiubo Li Li.Xiubo@freescale.com

sound/soc/generic/simple-card.c | 61 ++++++++++++++++++++--------------------- 1 file changed, 29 insertions(+), 32 deletions(-)

diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 986d2c7..cad2b30 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -163,6 +163,26 @@ asoc_simple_card_sub_parse_of(struct device_node *np, return 0; }

+static inline unsigned int +asoc_simple_card_fmt_master(struct device_node *np,

• 	    struct device_node *bitclkmaster,
  

• 	    struct device_node *framemaster)
  

+{

• switch (((np == bitclkmaster) << 4) | (np == framemaster)) {
• case 0x11:

• return SND_SOC_DAIFMT_CBS_CFS;
  

• case 0x10:

• return SND_SOC_DAIFMT_CBS_CFM;
  

• case 0x01:

• return SND_SOC_DAIFMT_CBM_CFS;
  

• default:

• return SND_SOC_DAIFMT_CBM_CFM;
  

• }
• /* Shouldn't be here */
• return -EINVAL;

+}

It will be nice if we declare the switch case numbers as macros (specific name)...