Thanks for the review comments,
On 24/04/18 17:17, Rob Herring wrote:
On Wed, Apr 18, 2018 at 04:31:40PM +0100, srinivas.kandagatla@linaro.org wrote:
From: Srinivas Kandagatla srinivas.kandagatla@linaro.org
This patch add DT bindings for ASM (Audio Stream Manager) DSP module.
Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org Reviewed-and-tested-by: Rohit kumar rohitkr@codeaurora.org
.../devicetree/bindings/sound/qcom,q6asm.txt | 33 ++++++++++++++++++++++ include/dt-bindings/sound/qcom,q6asm.h | 22 +++++++++++++++ 2 files changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt create mode 100644 include/dt-bindings/sound/qcom,q6asm.h
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6asm.txt b/Documentation/devicetree/bindings/sound/qcom,q6asm.txt new file mode 100644 index 000000000000..d034a50a202a --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,q6asm.txt @@ -0,0 +1,33 @@ +Qualcomm Audio Stream Manager (Q6ASM) binding
+Q6ASM is one of the APR audio service on Q6DSP. +Please refer to qcom,apr.txt for details of the coommon apr service bindings +used by the apr service device.
Need to be clear this is a child of APR.
Yep, I will add a line to state this explicitly.
+- but must contain the following property:
+- compatible:
- Usage: required
- Value type: <stringlist>
- Definition: must be "qcom,asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>".
Or "qcom,asm" where the version number can be queriedfrom DSP.example "qcom,asm-v2.0"+= ASM DAIs (Digial Audio Interface) +"dais" subnode of the ASM node represents dai specific configuration
+- #sound-dai-cells
- Usage: required
- Value type: <prop-encoded-array>
- Definition: Must be 1
+= EXAMPLE
+q6asm {
Unit address needed.
Agree, Will fix all such instances.
- compatible = "qcom,q6asm";
Doesn't match the doc.
Opps!! will fix all such instances with afe and asm too.