10 Jun
2015
10 Jun
'15
5:09 p.m.
On Wed, Jun 10, 2015 at 6:35 AM, Takashi Iwai tiwai@suse.de wrote:
At Fri, 05 Jun 2015 08:50:45 +0200, Clemens Ladisch wrote:
Adam Goode wrote:
/**
- \brief Get the card number of a client_info container
- \param info client_info container
- \return the card number, -1 if no card associated with this
client, or -ENOSYS if the
kernel does not support reporting this field- */
-1 is used as an out-of-range value when enumerating cards. However, I don't think this convention can be applied here, because the return value is also used for error codes, and -1 would correspond to -EPERM.
Squashing all error codes into -1 is not a good idea, so I think the value -1 should be converted into an appropriate error code, probably -ENXIO.
Agreed.
Also, please don't include irrelevant changes in configure.ac.
thanks,
Takashi
Thanks for the feedback, I should have time this week to get back to you.
Adam