15 Jun
2020
15 Jun
'20
2:17 p.m.
On Mon, Jun 15, 2020 at 11:24:33AM +0800, jack.yu@realtek.com wrote:
+enum {
- Enable_Boost,
- Bypass_Boost,
+};
This cleanup is nice but you should namespace the values here to ensure they don't collide with anything. We'd also tend to use all caps for enum items, same as macro names.
You should probably also explicitly assign the values for the constants to make sure it's clear how they line up with the control the user can see, eg:
RT1015_ENABLE_BOOST = 0,