On 9/17/19 12:55 AM, Greg KH wrote:
On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote:
+/**
- sdw_intel_probe() - SoundWire Intel probe routine
- @parent_handle: ACPI parent handle
- @res: resource data
- This creates SoundWire Master and Slave devices below the controller.
- All the information necessary is stored in the context, and the res
- argument pointer can be freed after this step.
- */
+struct sdw_intel_ctx +*sdw_intel_probe(struct sdw_intel_res *res) +{
- return sdw_intel_probe_controller(res);
+} +EXPORT_SYMBOL(sdw_intel_probe);
+/**
- sdw_intel_startup() - SoundWire Intel startup
- @ctx: SoundWire context allocated in the probe
- */
+int sdw_intel_startup(struct sdw_intel_ctx *ctx) +{
- return sdw_intel_startup_controller(ctx);
+} +EXPORT_SYMBOL(sdw_intel_startup);
Why are you exporting these functions if no one calls them?
They are used in the next series, see '[RFC PATCH 04/12] ASoC: SOF: Intel: add SoundWire configuration interface'
+int hda_sdw_startup(struct snd_sof_dev *sdev) +{ + struct sof_intel_hda_dev *hdev; + int ret; + + hdev = sdev->pdata->hw_pdata; + + ret = sdw_intel_startup(hdev->sdw); + if (ret < 0) + return ret; + hda_sdw_int_enable(sdev, true); + + return ret; +}
These 4 functions sdw_intel_acpi_scan, sdw_intel_probe, sdw_intel_startup and sdw_intel_exit are the interface between the ASoC world and the Soundwire/Intel module.
I split the patches in two series to make the review and integration easier on maintainers. The first one is strictly contained within the driver/soundwire directory while will impact the soundwire and ASoC trees.