On Mon, Jan 04, 2016 at 01:53:47PM +0530, Vinod Koul wrote:
On Mon, Dec 28, 2015 at 10:47:11PM +0800, Geliang Tang wrote:
dev_to_hdac is not used anymore so drop it.
No harm in keeping this for now as the systems using these will be coming up and more users will be upstreamed...
Thanks for your review. Sorry that I didn't make myself clear in the commit log. What I droped is a repetitive macro. dev_to_hdac() in hdac_ext_bus.c and dev_to_hdac_dev() in hdaudio.h are the same:
include/sound/hdaudio.h: #define dev_to_hdac_dev(_dev) container_of(_dev, struct hdac_device, dev)
sound/hda/ext/hdac_ext_bus.c: #define dev_to_hdac(dev) (container_of((dev), \ struct hdac_device, dev))
Users should use dev_to_hdac_dev() in hdaudio.h, not dev_to_hdac().
-Geliang
Signed-off-by: Geliang Tang geliangtang@163.com
sound/hda/ext/hdac_ext_bus.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c index 2433f7c..58f6b98 100644 --- a/sound/hda/ext/hdac_ext_bus.c +++ b/sound/hda/ext/hdac_ext_bus.c @@ -197,8 +197,6 @@ void snd_hdac_ext_bus_device_remove(struct hdac_ext_bus *ebus) } } EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_device_remove); -#define dev_to_hdac(dev) (container_of((dev), \
struct hdac_device, dev))static inline struct hdac_ext_driver *get_edrv(struct device *dev) { -- 2.5.0