On Wed, Feb 13, 2013 at 08:37:15AM +0100, Takashi Iwai wrote:
At Tue, 12 Feb 2013 22:35:47 -0800, Vinod Koul wrote:
On Wed, Feb 13, 2013 at 07:23:32AM +0100, Takashi Iwai wrote:
But this makes difficult to know which parameter is unavailable in this kernel, as already mentioned in the thread. You need to add another ioctl or add a mask in the struct. Or, take back to single key/value pairs, so user can see the -ENOENT or such error for non-existing parameters.
Right, but we have the API version.
But what if a driver doesn't support a particular metadata? Or would you mandate for every driver to support all metadata?
yes you have point. We cant expect everyone to support all metadate. So I think going back to simple single key/value is easy.
Driver cna implement what it supports and return error for ones it doesn't. This becomes scalable as well. But we can't keep them in core as we dont know which ones will change...
Expect updated patch soon :)
-- ~Vinod