Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

Hi Uwe,

On 11/26/20 8:59 AM, Uwe Kleine-König wrote:

The remove callback is only called for devices that were probed successfully before. As the matching probe function cannot complete without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to check this here.

Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de

I tested your two patches plus Leonard's patch 'ALSA: ppc: remove redundant checks in PS3 driver probe' applied to v5.9 on the PS3, and they seem to work fine.

Thanks for both your efforts.

Tested by: Geoff Levand geoff@infradead.org