On 14/06/2024 18:34, Piotr Wojtaszczyk wrote:
Add nxp,lpc3220-i2s DT binding documentation.
Signed-off-by: Piotr Wojtaszczyk piotr.wojtaszczyk@timesys.com
Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets.
b4 diff '20240614163500.386747-2-piotr.wojtaszczyk@timesys.com' Grabbing thread from lore.kernel.org/all/20240614163500.386747-2-piotr.wojtaszczyk@timesys.com/t.mbox.gz Checking for older revisions Grabbing search results from lore.kernel.org Nothing matching that query. --- Analyzing 24 messages in the thread Preparing fake-am for v2: ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs range: dda6bddbafe9..33a2a5c8fb4c Preparing fake-am for v3: ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding ERROR: Could not fake-am version v3 --- Could not create fake-am range for upper series v3
You are making review more difficult.
Changes for v3:
- Added '$ref: dai-common.yaml#' and '#sound-dai-cells'
- Dropped all clock-names, references
- Dropped status property from the example
- Added interrupts property
- 'make dt_binding_check' pass
Changes for v2:
- Added maintainers field
- Dropped clock-names
- Dropped unused unneded interrupts field
.../bindings/sound/nxp,lpc3220-i2s.yaml | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml
diff --git a/Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml b/Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml new file mode 100644 index 000000000000..04a1090f70cc --- /dev/null +++ b/Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/nxp,lpc3220-i2s.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: NXP LPC32XX I2S Controller
+description:
- The I2S controller in LPC32XX SoCs, ASoC DAI.
+maintainers:
- J.M.B. Downing jonathan.downing@nautel.com
- Piotr Wojtaszczyk piotr.wojtaszczyk@timesys.com
+allOf:
- $ref: dai-common.yaml#
+properties:
- compatible:
- enum:
- nxp,lpc3220-i2s- reg:
- maxItems: 1
- interrupts:
- maxItems: 1
- clocks:
- items:
- description: input clock of the peripheral.- dma-vc-names:
Missing vendor prefix... but I don't really get what's the point of this property.
- $ref: /schemas/types.yaml#/definitions/string-array
- description: |
names of virtual pl08x dma channels for tx and rxdirections in this order.- minItems: 2
- maxItems: 2
What part of hardware or board configuration this represents?
It wasn't here and nothing in changelog explained it.
Drop.
- "#sound-dai-cells":
- const: 0
Best regards, Krzysztof