On Tue, Nov 11, 2008 at 11:39 AM, Mark Brown broonie@sirena.org.uk wrote:
If you work with current git you'll see that the other drivers have been converted to pr_debug().
I see, I'm cloning git repository *now*.
they turn on/off an amplifier with 6db gain in the record and playback respectively.
Should be "ADC +6dB Switch" or similar then.
ack
A pointer to a table of dividers would handle it. In any case, it needs more comments.
ack,
You want to run this through scripts/checkpatch.pl.
I already did it
I'd have expected checkpatch to catch the extra space you've got after clk_source there...
I agree
This function is going to be used in a vtable where IIRC it can be optional but it needs to check the value of power in s3c24xx_uda1341_l3_pins. It feels like you've got too many layers of indirection here and that, for example, the l3_pins power should be assignable directly to the vtable.
ack
Thanks,