On 5/17/2023 12:11 AM, Krzysztof Kozlowski wrote:
On 16/05/2023 07:44, David Lin wrote:
Convert the NAU8810 audio CODEC bindings to DT schema.
Signed-off-by: David Lin CTLIN0@nuvoton.com
Thank you for your patch. There is something to discuss/improve.
+unevaluatedProperties: false
+examples:
- |
- i2c {
#address-cells = <1>;#size-cells = <0>;codec@1a {#sound-dai-cells = <0>;Please put sound-dai-cells at the end. In DTS convention is to have compatible first, reg second.
With this:
Reviewed-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
compatible = "nuvoton,nau8810";reg = <0x1a>;};- };
Best regards, Krzysztof
From your description, my understanding is since I set required items sequentially, one is compatible, the other is reg.
So the required properties should be filled in first, and the follow up properties are these optional properties.
________________________________ ________________________________ The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.