Hi Geert,
On Mon, Apr 25, 2022 at 5:14 PM Geert Uytterhoeven geert@linux-m68k.org wrote:
Hi Prabhakar,
On Mon, Apr 25, 2022 at 6:09 PM Lad, Prabhakar prabhakar.csengg@gmail.com wrote:
On Mon, Apr 25, 2022 at 1:49 PM Geert Uytterhoeven geert@linux-m68k.org wrote:
On Fri, Apr 22, 2022 at 7:32 PM Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com wrote:
Drop unused macros SSIFSR_TDC and SSIFSR_RDC.
Reported-by: Nobuhiro Iwamatsu nobuhiro1.iwamatsu@toshiba.co.jp Signed-off-by: Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com
Thanks for your patch!
What does this fix? Is the real issue that there are 32 FIFO entries, and the TDC and RDC fields are 6 bits wide, while the mask uses 0x1f instead of 0x3f?
I was in two minds here as you have already spotted the masks are incorrect, instead of fixing the masks I choose to drop the macros itself as they were not used. Let me know what are your thoughts on this.
IC.
I don't have a preference. So please either remove them, and make it clear they were wrong, so no one is tempted to just revert the removal to start using the definitions, or either keep them, and fix the definitions.
I'll go with dropping them and make it clear they were wrong.
Cheers, Prabhakar
Gr{oetje,eeting}s,
Geert-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds