18 Dec
2012
18 Dec
'12
1:09 p.m.
On 17 December 2012 21:25, Takashi Iwai tiwai@suse.de wrote:
Thanks for the revised patch.
No worries! Hope we can get it in soon.
+void mbox2_setup_48_24_magic(struct usb_device *dev)
This doesn't have to be global. Make it static.
Check
enablemagic[] and temp[] aren't used in this function. Remove them.
Check
(snd_printdd and snd_printd messages) Check
+int mbox2_skip_setting_quirk(struct snd_usb_audio *chip,
int iface, int altno)Where is this function called? I don't see the caller in your latest patch.
Well spotted! I believe this function is not required anymore because I have hardcoded the altsettings in the quirk definition.
Patch version 5 attached.
Regards, Damien