23 Oct
2019
23 Oct
'19
4:12 p.m.
On Wed, Oct 23, 2019 at 03:17:35PM +0200, Arnd Bergmann wrote:
On Wed, Oct 23, 2019 at 2:15 PM Krzysztof Kozlowski krzk@kernel.org wrote:
On Thu, Oct 10, 2019 at 10:29:55PM +0200, Arnd Bergmann wrote:
These can be build completely independently, so split the two Kconfig symbols. config DEBUG_S3C_UART0
depends on PLAT_SAMSUNG || ARCH_EXYNOS
depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS
How are you going to select DEBUG_S5PV210_UART now?
I don't see a problem here, the patch should not change the behavior at all.
The whole entry now looks like:
config DEBUG_S3C_UART0 depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS select DEBUG_EXYNOS_UART if ARCH_EXYNOS select DEBUG_S3C24XX_UART if ARCH_S3C24XX select DEBUG_S3C64XX_UART if ARCH_S3C64XX select DEBUG_S5PV210_UART if ARCH_S5PV210 bool "Use Samsung S3C UART 0 for low-level debug"
so this will work as before with any of ARCH_EXYNOS, ARCH_S3C24XX, ARCH_S3C64XX and ARCH_S5PV210.
What am I missing?
Ah, everything is OK, I mixed up removed with added line so it looked reversed (removal of ARCH_S5PV210).
Looks good.
Best regards, Krzysztof