On Thu, Jan 26, 2023 at 01:28:32AM +0000, Ki-Seok Jo wrote:
This at the very least needs a comment since it's not clear how someone would work that out from the code, there's no connection here to the mute operation so someone might just remove the delay. It may even be that this is happening well over 55ms after the mute happened. The ideal thing would be to track the time from the last mute, the regulator core does something along those lines with off_on_delay.
Currently mute control is registered in mute_stream function in dai operations. After that, amp shutdown is performed in DAPM PRE_PMD. Since a 55 ms delay was required in the meantime, it seems correct to change the position of the delay like you said. I will also include a comment about delay. Please reply if there is any problem.
I think that sounds fine.
Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to.
Thanks, I fixed the mail setting.
Seems not to have worked (at least for the text version) :/