On Thu, Oct 02, 2008 at 02:55:27PM +0530, Arun KS wrote:
ASoC codec driver for TLV320AIC23 device
Signed-off-by: Arun KS arunks@mistralsolutions.com
This looks good and it's probably as well to merge it now since the one issue below is mostly cosmetic so if nothing else it'll be easier to review incrementally so:
Acked-by: Mark Brown broonie@opensource.wolfsonmicro.com
+static const char *deemph_text[] = {"None", "32Khz", "44.1Khz", "48Khz"}; +static const char *sidetone_text[] = {"-6db", "-9db", "-12db", "-18db", "0db"};
...
+static const struct soc_enum tlv320aic23_sidetone =
- SOC_ENUM_SINGLE(TLV320AIC23_ANLG, 6, 5, sidetone_text);
...
- SOC_ENUM("Sidetone Gain", tlv320aic23_sidetone),
As I said on the last submission this should really be a SOC_SINGLE_TLV called "Sidetone Volume" rather than an enumeration - it's a dB scale controlling gain rather than an enumeration.