27 Oct
2023
27 Oct
'23
6:07 p.m.
On Fri, Oct 27, 2023 at 08:51:49AM +0200, Frieder Schrempf wrote:
On 26.10.23 22:03, kernel test robot wrote:
drivers/spi/spi-fsl-qspi.c: In function 'fsl_qspi_select_mem':
drivers/spi/spi-fsl-qspi.c:558:38: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]
558 | if (chip->rx_sample_delay_ns != spi->rx_sample_delay_ns | | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
IIRC, when I prepared the patches for sending "checkpatch.pl --strict" suggested to remove the parentheses here. Seems a bit inconsistent...
Ignore chekpatch, and it does look like as well as parentheses you should have used || not | here.