On Thu, May 28, 2015 at 05:13:13PM +0100, Richard Fitzgerald wrote:
On Thu, May 28, 2015 at 03:37:24PM +0100, Mark Brown wrote:
The default is that dev_dbg() is available in dmesg but not on the console which usually seems like a reasonable balance for this sort of thing - it's there if people want it but not included in the default logging.
What you're describing seems to be the default for dev_info(). For me I don't get any dev_dbg() output in the dmesg log unless the source file has a #define DEBUG at the top.
Interesting... the dev_dbg default appears to have been changed at some point, possibly with the addition of dynamic debug (which I tend to have on in my configurations and is common for distros and so on). The info default is overridden by a lot of distros. In any case, it's still the way we generally do debug - doing this on every DSP stop does seem quite chatty from a system point of view (and yes, some of the existing logging in the driver does seem a bit enthusiastic here too in retrospect, IIRC at the time request_firmware() was chatty too but that has been fixed).
Users will typically have the option to get this via ftrace as well (we have trace points for register read), and you might also want to consider the option of exporting the value via a sysfs file so people can grab the latest value whenever they like.