On Thu, 20 Sep 2007 14:20:01 +0200 Rene Herman rene.herman@gmail.com wrote:
FCC-ID I38-MMSN852: Aztech Sound Galaxy Waverider Pro 32-3D
I have tested your driver on this cards and it works for me (no suprise). I have no tested full-duplex recording.
Just two minor issues below.
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/isa/galaxy/Makefile Thu Sep 20 14:15:22 2007 +0200 @@ -0,0 +1,10 @@ +# +# Makefile for ALSA +# Copyright (c) 2001 by Jaroslav Kysela perex@suse.cz +#
You should be file's author, I suppose.
diff -r 0687faf0e009 isa/galaxy/galaxy.c --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/isa/galaxy/galaxy.c Thu Sep 20 14:15:22 2007 +0200 @@ -0,0 +1,562 @@ [...] +#define DSP_COMMAND_GALAXY_9 9 +#define GALAXY_COMMAND_WSSMODE 0 +#define GALAXY_COMMAND_SB8MODE 1
+#define GALAXY_MODE_WSS GALAXY_COMMAND_WSSMODE +#define GALAXY_MODE_SB8 GALAXY_COMMAND_SB8MODE
There is no need for these redefinitions. The first constant is used once, the second not even once. You can use the original name (GALAXY_COMMAND_WSSMODE) without losing readability.
Regards, Krzysztof
---------------------------------------------------------------------- Tutaj sa Twoi nowi znajomi! Sprawdz >>> http://link.interia.pl/f1bb7