On 14 December 2012 01:59, Takashi Iwai tiwai@suse.de wrote:
Some nitpicking about codes below:
Here you can reduce the indentation depth by simply returning the error
Check
(And, as you see, always put KERN_* prefix to *_printk(). Not necessarily for snd_printd() and snd_printdd(), if it's a debug message.
Check
Use msleep() for such a long delay.
Check
The same as firwamre size check. Handle the short error case and abort here. This reduces the indent level and improves the readability much better -- you don't have to consider a too long branching in your head while reading the code.
Check
snd_printk("device initialised!\n");Isn't it a debug message?
Check
The magic code is same as used in mbox2_skip_setting_quirk(). Move the code to a function and just call it from both places instead of keeping two open codes.
Check
Clemens wrote:
But while technically correct, the comment is superfluous because it doesn't say anything that isn't obvious from the code.
Check
See attached revised patch (version 3).
Regards, Damien