At Sun, 11 Jul 2010 12:16:36 +0200, Arnd Bergmann wrote:
This moves the lock_kernel() call from soundcore_open to the individual OSS device drivers, where we can deal with it one driver at a time if needed, or just kill off the drivers.
All core components in ALSA already provide adequate locking in their open()-functions and do not require the big kernel lock, so there is no need to add the BKL there.
Signed-off-by: Arnd Bergmann arnd@arndb.de
On Sunday 11 July 2010 09:15:22 Jaroslav Kysela wrote:
I don't see any reason (benefit) to add gotos to these two functions.
Sorry, I had removed them and then forgot the git-add before creating the emails. Originally, I had two patches, one for pushing down the BKL into every sound driver (hence the goto) and a second patch to remove the BKL again from all the native alsa drivers. If you prefer, I can also give you the separate patches, but I figured that since none of the ALSA drivers needs the BKL, the combined patch would be better.
This is the corrected combined version.
Thanks. I applied now to sound git tree (with a minor fix of coding-style in sound/oss/au1550_ac97.c).
BTW, do you have an updated patch for native_ioctl conversion wrt sound/*?
Takashi