26 May
2014
26 May
'14
3:26 p.m.
On 05/26/2014 02:08 PM, Vinod Koul wrote:
From: Subhransu S. Prusty subhransu.s.prusty@intel.com
For DSPs we need to set and get the value for snd_kcontrol. This is currently done by dapm_kcontrol_set/get_value, so create a wrapper snd_soc_dapm_kcontrol_get/set_value APIs to let drivers use this
Can you go a bit more into detail how you intend to use this?
[...] +unsigned int snd_soc_dapm_kcontrol_get_value(
- const struct snd_kcontrol *kcontrol)
+{
- dapm_kcontrol_get_value(kcontrol);
The compiler should have complained about this.
+} +EXPORT_SYMBOL_GPL(snd_soc_dapm_kcontrol_get_value);
I'm also not sure how much sense it makes to have a single line wrapper function for exporting things? Why not just rename the original function and then export it?