Hi,
On Tue, Jan 21, 2014 at 09:14:55PM +0000, Mark Brown wrote:
On Mon, Jan 20, 2014 at 01:05:55PM +0100, Markus Pargmann wrote:
- SOC_DOUBLE_R_S_TLV("PCM Playback Volume", AIC32X4_LDACVOL,
AIC32X4_RDACVOL, 0, (s8)0x81, 0x30, 7, 0, tlv_pcm),These casts are icky - I'd expect either signed numbers being used here or the macros to deal with any required casting. On the other hand there's fun and games with the type sizes...
I used this cast for the minimum value to get a easily comparable hex value. The reference manual does not state the real negative number, instead it show it in binary '0b1000 0001'. But I can convert those casted values to negative numbers.
Also this seems to depend on the patch series adding these controls, please note such dependencies when submitting.
Yes, sorry, I had it in the summary of the first version of this series, forgot to add it in the summary for v2.
Thanks,
Markus