Re: [alsa-devel] [PATCH RFT] ASoC: cs4271: Split SPI and I2C code into different modules

On Mon, Oct 06, 2014 at 11:09:47PM +0800, Axel Lin wrote:

Currently the cs4271 driver depends on SND_SOC_I2C_AND_SPI. So the driver cannot be built as built-in if CONFIG_I2C=m. Split SPI and I2C code into different modules to avoid this issue.

Applied, thanks.

#ifdef CONFIG_OF -static const struct of_device_id cs4271_dt_ids[] = { +const struct of_device_id cs4271_dt_ids[] = { { .compatible = "cirrus,cs4271", }, { } }; MODULE_DEVICE_TABLE(of, cs4271_dt_ids); +EXPORT_SYMBOL_GPL(cs4271_dt_ids); #endif

I do now find myself wondering if this actually does the right thing (it could if the tools are smart enough) but it's not like this is the first driver to do this so not a problem here.