Re: [PATCH] ALSA: Use fallthrough pseudo-keyword

8 Jul 2020

On Tue, 07 Jul 2020 19:28:47 +0200,
Gustavo A. R. Silva wrote:
...

--- a/sound/isa/msnd/msnd_pinnacle_mixer.c
+++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
@@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right)
   case MSND_MIXER_VOLUME:		/* master volume */
   	writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft);
   	writew(wRight, dev->SMA + SMA_wCurrMastVolRight);

/* fall through */





fallthrough;

case MSND_MIXER_AUX:			/* aux pot control */
/* scaled by master volume */
/* fall through */

Any reason to leave this?
thanks,
Takashi

    

Takashi Iwai