Re: [alsa-devel] [PATCHv4] ASoC: Add support for BCM2835

On Fri, Nov 22, 2013 at 02:32:19PM +0100, Florian Meier wrote:

...

• dev = devm_kzalloc(&pdev->dev, sizeof(*dev),

• 	   GFP_KERNEL);
  

• if (IS_ERR(base))

• return PTR_ERR(base);
  

Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev).

No, it should be a check for NULL and returning -ENOMEM.

Is the patch acceptable apart from that now?

Not looked yet.