Re: [alsa-devel] [PATCH] ASoC: samsung: i2s: Supported high resolution rates

Hi Jaechul,

This driver can support more frequencies over 96KHz. There are no reasons to limit the frequency range below 96KHz. If codecs/amps or something else can't support high resolution rates, the constraints would be set rates properly because each drivers have its own limits.

That's a good commit introduction, but you are not explaining what you actually did. Please explain better how you fixed the issue.

"> Supported high resolution rates"

In the patch title, please use the imperative form, not "supported" but "support".

• if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node)

I do not like drivers to check the Kernel's configuration, I think just checking "pdev->dev.of_node" is enough.

The rest looks good.

Andi