Re: [alsa-devel] [PATCH 5/8] ASoC: fsi: modify wrong value setting order of TDM

On Mon, Jul 12, 2010 at 02:56:17PM +0900, Kuninori Morimoto wrote:

channel size should be set before setting register value

So, this looks like a bug fix which should go into 2.6.35 but...

case SH_FSI_FMT_TDM:

• data = CR_TDM | (fsi->chan - 1);
  

  fsi->chan = is_play ? SH_FSI_GET_CH_O(flags) : SH_FSI_GET_CH_I(flags);

• data = CR_TDM | (fsi->chan - 1);
  

  break;

...it depends on your earlier patch to change the CR_ macros which is just a coding style tweak and so should wait for 2.6.36.

When preparing patches it's good to separate out things like cleanups and new features from bug fixes - the bug fixes we want to get into the next release if possible, but other things are supposed to wait for the next kernel development cycle.