Re: [alsa-devel] [PATCH] ASoC:pcm512x: Make PLL lock output selectable via device tree.

On Fri, Mar 20, 2015 at 09:22:43PM +0000, Howard Mitchell wrote:

• if (pcm512x->pll_lock) {

•            if (of_property_read_u32(np, "pll-lock", &val) >= 0) {
  

•                    if (val > 6) {
  

•                            dev_err(dev, "Invalid pll-lock\n");
  

•                            ret = -EINVAL;
  

•                            goto err_clk;
  

•                    }
  

•                    pcm512x->pll_lock = val;
  

•            }
  

This breaks existing boards which rely on GPIO 4 being set as the lock output. This is very unfortunate since it's a silly thing for the driver to default to but nontheless we should really continue to support them - at a guess Peter's board is relying on this, and even if it isn't someone else's might.