On Wed, 25 Jun 2008 16:40:33 +0100 "ext Liam Girdwood" lg@opensource.wolfsonmicro.com wrote:
Any chance you could also add a little text to Docs/sound/alsa/soc/dapm.txt for this.
Documentation? That's difficult and actually forgot it completely :-)
But is it documented already? "There are convience macros defined in soc-dapm.h that can be used to quickly build a list of widgets of the codecs and machines DAPM widgets."
Sorry, just to clarify, I was meaning 1 line in section 2 of dapm.txt (the widget type table). Just a little description next to the others.
A diff like below looks bit confusing since the patch itself doesn't add anything new into enum snd_soc_dapm_type. What would you think?
Jarkko
diff --git a/Documentation/sound/alsa/soc/dapm.txt b/Documentation/sound/alsa/soc/dapm.txt index c784a18..d621b50 100644 --- a/Documentation/sound/alsa/soc/dapm.txt +++ b/Documentation/sound/alsa/soc/dapm.txt @@ -64,6 +64,7 @@ Audio DAPM widgets fall into a number of types:- o Speaker - Speaker o Pre - Special PRE widget (exec before all others) o Post - Special POST widget (exec after all others) + o Generic - Generic register modifier widget which can have any type above
(Widgets are defined in include/sound/soc-dapm.h)