29 Jul
2021
29 Jul
'21
11:03 p.m.
On 7/26/21 6:14 PM, Pierre-Louis Bossart wrote:
OK. Will remove those unnecessary NULL inits and reverse xmas tree the declarations.
so here you will disable regulators that have not been enabled, is it intentional?
mixing gotos and returns is confusing...
and in addition you will set the reset_gpio that you only get a couple of lines below, that will be a page fault?
Not intentional. I think regulator enable should be moved before handling pdata. (and every error after regulator enable will use goto instead of return)
The GPIO descriptor is validated so if it is not present or not yet requested gpiod_set_value should just return without any faults.
Thanks, David