On Mon, Dec 14, 2009 at 04:45:18PM +0100, Jaroslav Kysela wrote:
On Mon, 14 Dec 2009, Takashi Iwai wrote:
Where's your Signed-off-by: line? You rely on the SCM system to obtain this information from the 'Merge' commit. I don't think that it's good.
This is fully normal. Do you see sign-off in each pull by Linus?
Linus should be only exception, because this patch route is quite obvious.
Many trees with sub-trees or sub-projects are done in that way. See x86 tree, for example.
It does not mean that it's the correct way.
It's been discussed relatively often on the lists - the general position is that so long as the last person to sign off is the person who created the actual commit everything is fine. If the commit gets changed (as a result of a rebase or whatever) then you need to add a new signoff but otherwise we can be sure that the commit will not have changed since the SHA1 would change if there were changes so there's no question of any licensing issues.