Re: [alsa-devel] [PATCH 01/10] ASoc: mxs: add mxs-pcm driver

On Fri, Jul 08, 2011 at 11:59:41PM +0800, Dong Aisheng wrote:

Signed-off-by: Dong Aisheng b29396@freescale.com

*Always* CC maintainers on patches.

• • Copyright (C) 2011 Freescale Semiconductor, Inc. All Rights Reserved.
• • Refer to sound/soc/imx/imx-pcm-dma-mx2.c

Why?

• iprtd->buf = (unsigned int *)substream->dma_buffer.area;

This cast looks incredibly suspicious...

+static int snd_mxs_pcm_prepare(struct snd_pcm_substream *substream) +{

• return 0;

+}

Remove empty functions.

+static int snd_mxs_pcm_trigger(struct snd_pcm_substream *substream, int cmd) +{

• struct snd_pcm_runtime *runtime = substream->runtime;
• struct mxs_pcm_runtime_data *iprtd = runtime->private_data;
• switch (cmd) {
• case SNDRV_PCM_TRIGGER_START:
• case SNDRV_PCM_TRIGGER_RESUME:
• case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:

• dmaengine_submit(iprtd->desc);
  

• break;
  

Why the random blank line?

+static struct platform_driver mxs_pcm_driver = {

• .driver = {

• 	.name = "mxs-pcm-audio",
  

• 	.owner = THIS_MODULE,
  

Indentation here is very odd...