On Thu, Jan 7, 2021 at 10:28 PM Mark Brown broonie@kernel.org wrote:
On Thu, Jan 07, 2021 at 05:06:22PM +0800, Chris Chiu wrote:
+static const struct acpi_gpio_mapping *cht_rt5645_gpios;
You're adding a read only static variable with no way to set it. This doesn't actually do anything?
This is a pointer to a 'const 'struct acpi_gpio_mapping', and I will need it to point to the 'static const struct acpi_gpio_mapping cht_rt5645_ef20_gpios[]' in my consequent patch '[PATCH 2/4] ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series'.
I take the same idea from 'sound/soc/intel/boards/bytcr_rt5651.c' line 90. And it did work as expected on my ECS EF20EA
@@ -3780,7 +3782,6 @@ static const struct dmi_system_id dmi_platform_data[] = { }, .driver_data = (void *)&intel_braswell_platform_data, },
{ }};
This is an unrelated change which removes the terminator on the array which will cause issues.
Thanks for pointing that out. It's not my intention. I accidentally removed it. I'll fix this in v3.
Chris