Re: [alsa-devel] [PATCH v6] sound/soc/lapis: add machine driver for ML7213 Carrier Board

On Fri, Mar 09, 2012 at 03:38:11PM +0900, Tomoya MORINAGA wrote:

• /* set codec DAI configuration */
• ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |

• 		 SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS);
  

• if (ret < 0)

• return ret;
  

• /* set cpu DAI configuration */
• ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_I2S |

• 		 SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBM_CFM);
  

This looks very broken, you're setting the two ends of the link to different configurations. If this is needed it should be documented why.

Also, this should be set in the dai_link structure as data rather than set each time.