3 Oct
2008
3 Oct
'08
11:06 a.m.
On Fri, 2008-10-03 at 11:18 +0300, Tony Lindgren wrote:
Hi,
- Arun KS arunks@mistralsolutions.com [081002 12:18]:
ASoC codec driver for TLV320AIC23 device
One comment below based on a quick browse.
<snip>
+static void tlv320aic23_shutdown(struct snd_pcm_substream *substream) +{
- struct snd_soc_pcm_runtime *rtd = substream->private_data;
- struct snd_soc_device *socdev = rtd->socdev;
- struct snd_soc_codec *codec = socdev->codec;
- /* deactivate */
- if (!codec->active) {
udelay(50);tlv320aic23_write(codec, TLV320AIC23_ACTIVE, 0x0);- }
+}
What's the purpose of the udelay() here? Looks like if needed it should be after the twl32aic23_write().. Otherwise the problem is probably somewhere else.
Iirc this was found to reduce pops and clicks on shutdown on another very similar codec in this family.
Liam